Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procedures: Che In Unsupported OIDC Kubernetes #1

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Conversation

maheshrajrp
Copy link
Owner

@maheshrajrp maheshrajrp commented Mar 6, 2024

What does this pull request change?

Addition of Che in OIDC Unsupported Kubernetes

What issues does this pull request fix or reference?

eclipse-che/che#22845

Specify the version of the product this pull request applies to

7.82

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@maheshrajrp maheshrajrp marked this pull request as ready for review March 6, 2024 18:26
Copy link

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for missing attribute warning in the build + validate PR workflow

+
[source,shell,subs="+attributes"]
----
KEYCLOAK_HOST=keycloak.${DOMAIN_NAME}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KEYCLOAK_HOST=keycloak.${DOMAIN_NAME}
KEYCLOAK_HOST=keycloak.$\{DOMAIN_NAME}

Use the following command to wait until {kubernetes} host is known:
[source,shell,subs="attributes+"]
----
until ping -c1 ${DOMAIN_NAME} >/dev/null 2>&1; do :; done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
until ping -c1 ${DOMAIN_NAME} >/dev/null 2>&1; do :; done
until ping -c1 $\{DOMAIN_NAME} >/dev/null 2>&1; do :; done

Use the following command to wait until `Keycloak` host is known:
[source,shell,subs="attributes+"]
----
until ping -c1 ${KEYCLOAK_HOST} >/dev/null 2>&1; do :; done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
until ping -c1 ${KEYCLOAK_HOST} >/dev/null 2>&1; do :; done
until ping -c1 $\{KEYCLOAK_HOST} >/dev/null 2>&1; do :; done

isCA: false
commonName: keycloak
dnsNames:
- ${KEYCLOAK_HOST}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ${KEYCLOAK_HOST}
- $\{KEYCLOAK_HOST}

ingressClassName: nginx
tls:
- hosts:
- ${KEYCLOAK_HOST}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ${KEYCLOAK_HOST}
- $\{KEYCLOAK_HOST}

- ${KEYCLOAK_HOST}
secretName: keycloak.tls
rules:
- host: ${KEYCLOAK_HOST}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- host: ${KEYCLOAK_HOST}
- host: $\{KEYCLOAK_HOST}

api:
image: registry.k8s.io/kube-apiserver:v1.27.1
extraArgs:
- --oidc-issuer-url=https://${KEYCLOAK_HOST}/realms/che

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --oidc-issuer-url=https://${KEYCLOAK_HOST}/realms/che
- --oidc-issuer-url=https://$\{KEYCLOAK_HOST}/realms/che

--exec-arg=\
oidc-login,\
get-token,\
--oidc-issuer-url=https://${KEYCLOAK_HOST}/realms/che,\

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--oidc-issuer-url=https://${KEYCLOAK_HOST}/realms/che,\
--oidc-issuer-url=https://$\{KEYCLOAK_HOST}/realms/che,\

…al-kubernetes-cluster.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Copy link

⚡️ Deploying pull request preview...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants