Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YAML encoding #52

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Fix YAML encoding #52

merged 1 commit into from
Jan 8, 2019

Conversation

RomanKornev
Copy link
Contributor

Closes #50

@mahmoud
Copy link
Owner

mahmoud commented Jan 8, 2019

Interesting. While #50 wasn't reproducible for me, this doesn't seem like it'll hurt, so let's try it out!

@mahmoud mahmoud merged commit c95068e into mahmoud:master Jan 8, 2019
@RomanKornev
Copy link
Contributor Author

Should we even support Python 2 at this point?
Py2 doesn't have encoding argument so this change breaks backwards compatibility.

@mahmoud
Copy link
Owner

mahmoud commented Jan 8, 2019

Nah, no py2 support necessary. Soon here, we'll be generating multiple docs off projects.yaml and I'll have CI do the build (#17), so neither 2 nor 3 will be required :)

@RomanKornev
Copy link
Contributor Author

Nice!

@RomanKornev RomanKornev deleted the fix-encoding branch January 8, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanKornev @mahmoud