Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make it clearer what the file address is after uploading a file in the console output #2014

Closed
mickvandijke opened this issue Jul 30, 2024 · 1 comment · Fixed by #2018
Assignees

Comments

@mickvandijke
Copy link
Contributor

When running the file upload command, on completion instead of outputting the file address next to the original filename: <FILENAME> <FILE_ADDRESS>, make it explicit that it is the file address: File Address: <FILE_ADDRESS>.

Example of what it outputs now (user has to guess that this is the file address):

safe_cli: "10KB-da03f3dac64ee2eb911f53fd6ce63efbf98e9c729d166a2b8194d316211ac2ff.bin" 76b689904c4b8121136d853afd5545d1cac269bdb97c21bfaa1c3f516467f875

Instead, do this:

safe_cli: "10KB-da03f3dac64ee2eb911f53fd6ce63efbf98e9c729d166a2b8194d316211ac2ff.bin", File Address: 76b689904c4b8121136d853afd5545d1cac269bdb97c21bfaa1c3f516467f875

Makes it easier for log parsers to find the file address :)

@mickvandijke mickvandijke self-assigned this Jul 30, 2024
@happybeing
Copy link
Contributor

FYI, if you are talking about the output to the terminal, the current arrangement was designed to match the parameters for safe files download.

mickvandijke added a commit to mickvandijke/safe_network that referenced this issue Jul 31, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 31, 2024
…e-address

chore(cli): [#2014] explicitly show the uploaded file's address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants