chore(node): check confirmed_spend existence #2020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve error handling and code clarity in the
sn_node
andsn_transfers
modules. The most important changes involve refining the logic for detecting spent transactions and updating the method for checking file existence.Improvements to error handling and code clarity:
sn_node/src/put_validation.rs
: Updated the logic to handle different outcomes ofwallet.get_confirmed_spend(spend_addr)
, including logging an error when an error is encountered and providing more specific warnings for different cases.sn_transfers/src/wallet/wallet_file.rs
: Changed the method for checking if a file exists fromis_file()
toexists()
to improve clarity and correctness.