Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): check confirmed_spend existence #2020

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

maqi
Copy link
Member

@maqi maqi commented Aug 1, 2024

This pull request includes changes to improve error handling and code clarity in the sn_node and sn_transfers modules. The most important changes involve refining the logic for detecting spent transactions and updating the method for checking file existence.

Improvements to error handling and code clarity:

  • sn_node/src/put_validation.rs: Updated the logic to handle different outcomes of wallet.get_confirmed_spend(spend_addr), including logging an error when an error is encountered and providing more specific warnings for different cases.
  • sn_transfers/src/wallet/wallet_file.rs: Changed the method for checking if a file exists from is_file() to exists() to improve clarity and correctness.

@joshuef joshuef added this pull request to the merge queue Aug 2, 2024
Merged via the queue into maidsafe:main with commit 13b885a Aug 2, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants