Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evm network in client config #2609

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add evm network in client config #2609

merged 2 commits into from
Jan 7, 2025

Conversation

mickvandijke
Copy link
Contributor

@mickvandijke mickvandijke commented Jan 7, 2025 •
edited
Loading

  • Adds evm_network field to ClientConfig.
  • Changes the default EvmNetwork to EvmNetwork::ArbitrumSepolia.

grumbach
grumbach approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@grumbach grumbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickvandijke mickvandijke enabled auto-merge January 7, 2025 15:31
@mickvandijke mickvandijke added this pull request to the merge queue Jan 7, 2025
Merged via the queue into maidsafe:main with commit ac85238 Jan 7, 2025
26 checks passed
@mickvandijke mickvandijke deleted the feat-evm-network-in-client-config branch January 7, 2025 16:30
mickvandijke added a commit to mickvandijke/safe_network that referenced this pull request Jan 7, 2025
@mickvandijke
Merge pull request maidsafe#2609
904b201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grumbach grumbach grumbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickvandijke @grumbach