refactor!: Remove no-igd feature

Since `igd` is already an optional dependency, we already have an `igd`
feature which is enabled by default. To disable IGD, we can simply use
`default-features = false` or `--no-default-features`.

BREAKING CHANGE: The `no-igd` feature has been removed.

Cargo.toml

@@ -74,4 +74,3 @@ tracing-subscriber = "0.2.19"
 
 [features]
 default = [ "igd" ]
-no-igd = [ ]

src/endpoint.rs

@@ -9,7 +9,7 @@
 
 use crate::connection_pool::ConnId;
 
-#[cfg(not(feature = "no-igd"))]
+#[cfg(feature = "igd")]
 use super::igd::{forward_port, IgdError};
 use super::wire_msg::WireMsg;
 use super::{
@@ -38,7 +38,7 @@ use tracing::{debug, error, info, trace, warn};
 const CERT_SERVER_NAME: &str = "MaidSAFE.net";
 
 // Number of seconds before timing out the IGD request to forward a port.
-#[cfg(not(feature = "no-igd"))]
+#[cfg(feature = "igd")]
 const PORT_FORWARD_TIMEOUT: Duration = Duration::from_secs(30);
 
 // Number of seconds before timing out the echo service query.
@@ -144,7 +144,7 @@ impl<I: ConnId> Endpoint<I> {
         let contact = endpoint.connect_to_any(contacts).await;
         let public_addr = endpoint.resolve_public_addr(contact).await?;
 
-        #[cfg(not(feature = "no-igd"))]
+        #[cfg(feature = "igd")]
         if endpoint.config.forward_port {
             timeout(
                 PORT_FORWARD_TIMEOUT,

src/error.rs

@@ -9,7 +9,7 @@
 
 use super::wire_msg::WireMsg;
 use crate::config::ConfigError;
-#[cfg(not(feature = "no-igd"))]
+#[cfg(feature = "igd")]
 use crate::igd::IgdError;
 use bytes::Bytes;
 use std::{fmt, io, net::SocketAddr};
@@ -38,7 +38,7 @@ pub enum EndpointError {
     },
 
     /// Failed to establish UPnP port forwarding.
-    #[cfg(not(feature = "no-igd"))]
+    #[cfg(feature = "igd")]
     #[error(transparent)]
     Upnp(#[from] UpnpError),
 
@@ -69,7 +69,7 @@ impl From<quinn::EndpointError> for EndpointError {
     }
 }
 
-#[cfg(not(feature = "no-igd"))]
+#[cfg(feature = "igd")]
 impl From<IgdError> for EndpointError {
     fn from(error: IgdError) -> Self {
         Self::Upnp(UpnpError(error))
@@ -466,7 +466,7 @@ pub enum StreamError {
 pub struct UnsupportedStreamOperation(Box<dyn std::error::Error + Send + Sync>);
 
 /// Failed to establish UPnP port forwarding.
-#[cfg(not(feature = "no-igd"))]
+#[cfg(feature = "igd")]
 #[derive(Debug, Error)]
 #[error("Failed to establish UPnP port forwarding")]
 pub struct UpnpError(#[source] IgdError);

src/lib.rs

@@ -53,7 +53,7 @@ mod connection_pool;
 mod connections;
 mod endpoint;
 mod error;
-#[cfg(not(feature = "no-igd"))]
+#[cfg(feature = "igd")]
 mod igd;
 mod utils;
 mod wire_msg;
@@ -62,7 +62,7 @@ pub use config::{Config, ConfigError};
 pub use connection_pool::ConnId;
 pub use connections::{DisconnectionEvents, RecvStream, SendStream};
 pub use endpoint::{Endpoint, IncomingConnections, IncomingMessages};
-#[cfg(not(feature = "no-igd"))]
+#[cfg(feature = "igd")]
 pub use error::UpnpError;
 pub use error::{
     ClientEndpointError, Close, ConnectionError, EndpointError, InternalConfigError, RecvError,