Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify effects of using php-http/discovery #889

Open
igorsantos07 opened this issue Dec 29, 2023 · 0 comments
Open

Clarify effects of using php-http/discovery #889

igorsantos07 opened this issue Dec 29, 2023 · 0 comments

Comments

@igorsantos07
Copy link
Contributor

igorsantos07 commented Dec 29, 2023

I got into several trouble trying to cleanup our project's dependency file, which is quite big. Turns out, after several hoops and loops, I understood that Mailgun forces a peer dependency for HTTP work - that's not clear since the dependency gets forced into our root require, Composer doesn't allow proper comments, and composer why can't help either.

I suggested them to output the plugin effects (php-http/discovery#258), but Mailgun's README could be clearer as well. Instead of just saying "we need some extra packages; if you're in a hurry, just install those two", explain that there's a plugin which will force installation of some PSR implementation, even if it's not one of those you're suggesting.

igorsantos07 added a commit to igorsantos07/mailgun-php that referenced this issue Dec 29, 2023
According to the source, Mailgun uses `Discovery\Psr17FactoryDiscovery` and `Psr18ClientDiscovery`; thus, docs should like to factory and not message implementations.

Related to mailgun#889.
igorsantos07 added a commit to igorsantos07/mailgun-php that referenced this issue Dec 29, 2023
According to the source, Mailgun uses `Discovery\Psr17FactoryDiscovery` and `Psr18ClientDiscovery`; thus, docs should like to factory and not message implementations.

Related to mailgun#889.
oleksandr-mykhailenko pushed a commit that referenced this issue Jan 8, 2024
According to the source, Mailgun uses `Discovery\Psr17FactoryDiscovery` and `Psr18ClientDiscovery`; thus, docs should like to factory and not message implementations.

Related to #889.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant