Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update superagent and superagent-proxy dependencies #134

Merged
merged 2 commits into from
May 21, 2021

Conversation

katafractari
Copy link
Contributor

Addressing #128
Tests are green in my local environment. We are already using this version in our application without any apparent problems.

@kenjinsama
Copy link

I approve this since it cause many problems with proxies that were resolved since : TooTallNate/node-agent-base#35

See the dependencies:

npm ls agent-base
fc@0.0.2 /home/stephane/Projets/franceconnect/fc/back
└─┬ node-mailjet@3.3.1
  └─┬ superagent-proxy@1.0.3
    └─┬ proxy-agent@2.3.1
      ├── agent-base@4.3.0 
      ├─┬ http-proxy-agent@2.1.0
      │ └── agent-base@4.3.0  deduped
      ├─┬ https-proxy-agent@2.2.4
      │ └── agent-base@4.3.0  deduped
      ├─┬ pac-proxy-agent@2.0.2
      │ └── agent-base@4.3.0  deduped
      └─┬ socks-proxy-agent@3.0.1
        └── agent-base@4.3.0  deduped

@satyavh
Copy link

satyavh commented Jan 10, 2021

This merge is required for Mailjet not conflicting with other packages. When will this be merged?

@kenjinsama
Copy link

Is there still someone here that maintains the pull requests 😢 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants