refactor(unauthenticated-route-mixin): Move redirection logic for thi… #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s mixin into a function - simple the same thing as mainmatter#1655 does for authenticated-route-mixin
mike-north
approved these changes
Aug 31, 2018
marcoow
reviewed
Aug 31, 2018
| @public | ||
| */ | ||
| beforeModel() { | ||
| if (this.get('session').get('isAuthenticated')) { | ||
| const didRedirect = runIfAuthenticated(getOwner(this), () => { |
There was a problem hiding this comment.
Not something that needs to be fixed before this can be merged (it's in the other PR as well) but that we should clean up at some point: this variable doesn't really indicate whether there was a redirect in the callback but whether the session was authenticated or not - not a big deal but this makes following what's going on unnecessarily complicated.
There was a problem hiding this comment.
great point. A tuple might be appropriate for a future PR
const [didRedirect, reason] = runIfAuthenticated(...);
marcoow
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s mixin into a function