Simplified cross domain check a little by using jQuery. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the |
|
Those docs indicate it will be set to true for cross domain requests. Also, I believe that's the point of providing two options arguments to Finally, in the source, it's certainly being set. |
|
Hm, I thought I tried to use it once and it didn't woe las expected. Can you add a test and see whether it actually works as expected? |
|
These tests already cover this. |
|
You're right - no idea why that didn't work (or I thought it didn't work) when I tried it... |
|
merged 9f3e081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to make sense to me to use jQuery to check for whether or not the request is cross-domain since jQuery already does this for us.