Remove deprecations and drop support for Ember < 3.0 #1933
Conversation
|
@sdebarros we should remove the old testing style as well - I'll create a PR deprecating that. |
README.md
Outdated
| }); | ||
| }); | ||
| ``` | ||
|
|
||
| If you're an `ember-mocha` user, we can recommend to check out this | ||
| [example from the test suite of ember-simple-auth itself](https://github.com/simplabs/ember-simple-auth/blob/master/tests/acceptance/authentication-test.js). | ||
|
|
There was a problem hiding this comment.
We should also remove information on the old testing API from the README: https://github.com/simplabs/ember-simple-auth#ember-cli-qunit-410-and-earlier
There was a problem hiding this comment.
There was a problem hiding this comment.
since we're removing the old info, we should also change the intro to the now only section on testing: https://github.com/simplabs/ember-simple-auth#ember-cli-qunit-420-and-greater-or-ember-qunit-320-and-greater I guess we can simply remove most of that intro.
There was a problem hiding this comment.
I'll update the intro. I think we should still mention the dependency on ember-cli-qunit 4.2+, seems like ember-cli 3.0 was still using a lower version. Not sure if there's still people with that version, but just in case.
marcoow
changed the title
This removes deprecated code as well as support for Ember < 3.0 in preparation for a major version release.
TODO