Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node 6 #1956

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Drop support for Node 6 #1956

merged 1 commit into from
Sep 25, 2019

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Sep 25, 2019

…as it is EOL

Turbo87
Turbo87 approved these changes Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for ember-cookies applies. in this case we should consider if we have any other breaking changes that we would want to do at the same time.

@marcoow
Copy link
Member Author

marcoow commented Sep 25, 2019

Yes, this will be part of a 2.0 release. @sdebarros had included it in #1938 but merging this separately now allows us to get all the currently broken @dependabot-bot PRs in.

@marcoow marcoow merged commit a098f8f into master Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the node-8 branch September 25, 2019 15:13
@Turbo87 Turbo87 mentioned this pull request Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoow @Turbo87