Fix deprecations regarding Computed Property Overrides #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
force-pushed
the
fix-cp-override
branch
from
1cc375a
to
944b930
Compare
marcoow
force-pushed
the
fix-cp-override
branch
from
cf1c4c3
to
1f3b12a
Compare
sdebarros
reviewed
Jan 31, 2020
sdebarros
approved these changes
Jan 31, 2020
Co-Authored-By: Samanta de Barros <samanta.debarros@simplabs.com>
|
Great, thanks for the merge. Could we get a new NPM release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the deprecations regarding overridden computed properties. Most of these CPs were only used in testing and should be properly mocked via the container anyway (e.g.
_fastBoot).TODO
closes #1908
closes #2044
closes #1938