Fix handling of login errors in the dummy app #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
force-pushed
the
fix-login-error-handling-in-dummy-app
branch
from
6a83783
to
628d659
Compare
Merged
I'm confused by this. Do we not reject with an see https://eslint.org/docs/rules/prefer-promise-reject-errors |
|
No, unfortunately we do not reject with an |
Turbo87
reviewed
Mar 18, 2020
marcoow
force-pushed
the
fix-login-error-handling-in-dummy-app
branch
from
318b108
to
5189c62
Compare
marcoow
force-pushed
the
fix-login-error-handling-in-dummy-app
branch
from
5189c62
to
917b8bc
Compare
marcoow
force-pushed
the
fix-login-error-handling-in-dummy-app
branch
from
917b8bc
to
1902463
Compare
marcoow
force-pushed
the
fix-login-error-handling-in-dummy-app
branch
from
1902463
to
72e9533
Compare
marcoow
force-pushed
the
fix-login-error-handling-in-dummy-app
branch
from
72e9533
to
f42dc8e
Compare
Turbo87
approved these changes
Apr 8, 2020
delete-merged-branch
bot
deleted the
fix-login-error-handling-in-dummy-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes handling of login errors in the dummy app. Since version 3.0 we no longer reject with the error response's (JSON) body but with the response itself – the dummy app had not been updated accordingly yet.