Unset attemptedTransition on invalidation #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
force-pushed
the
unset-attempted-transition-on-invalidation
branch
from
16ef3c0
to
e26d55a
Compare
sdebarros
approved these changes
Aug 27, 2020
delete-merged-branch
bot
deleted the
unset-attempted-transition-on-invalidation
branch
sdebarros
pushed a commit
that referenced
this pull request
Oct 16, 2020
sdebarros
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the
sessionservice'sattemptedTransitionproperty is cleared when the session is invalidated. Otherwise you could run into situations where a user logs in and they are redirected to a route that they have tried to access previously but that transition did not actually trigger the current redirect to the login route (or there was no redirect at all and they just clicked on a direct link to the login route).closes #2176