Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tryInvoke usage #2266

Merged
merged 1 commit into from
May 7, 2021
Merged

remove tryInvoke usage #2266

merged 1 commit into from
May 7, 2021

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Feb 1, 2021

As tryInvoke seems to be deprecated

marcoow
marcoow approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Linting seems to fail though – I assume the eslint config needs to be changed or we'll have to use something like

server && server.shutdown();

@bekzod
Copy link
Contributor Author

bekzod commented Mar 30, 2021

@marcoow thank you, updated

@bekzod bekzod changed the title replace tryInvoke with optional chaining remove tryInvoke usage Mar 30, 2021
@marcoow marcoow merged commit 55bc5df into mainmatter:master May 7, 2021
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekzod @marcoow