Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ESA version from ember inspector #2321

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

brunoocasali
Copy link
Contributor

Closes #2303
Closes #2309

@brunoocasali brunoocasali changed the title Remove ESA version Remove ESA version from ember inspector Sep 9, 2021
@brunoocasali brunoocasali marked this pull request as ready for review September 9, 2021 21:09
Copy link
Collaborator

@BobrImperator BobrImperator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BobrImperator
Copy link
Collaborator

It seems like we have some linting issues on this PR, could you please fix them @brunoocasali?

@brunoocasali
Copy link
Contributor Author

@BobrImperator could you please accept the workflow execution?

@BobrImperator BobrImperator merged commit d9cac59 into mainmatter:master Sep 24, 2021
@brunoocasali brunoocasali deleted the remove-esa-version branch September 24, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants