-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ESA version from ember inspector #2321
Merged
BobrImperator
merged 3 commits into
mainmatter:master
from
brunoocasali:remove-esa-version
Sep 24, 2021
Merged
Remove ESA version from ember inspector #2321
BobrImperator
merged 3 commits into
mainmatter:master
from
brunoocasali:remove-esa-version
Sep 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
changed the title
Remove ESA version
Remove ESA version from ember inspector
Sep 9, 2021
josemarluedke
approved these changes
Sep 10, 2021
BobrImperator
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
marcoow
approved these changes
Sep 24, 2021
It seems like we have some linting issues on this PR, could you please fix them @brunoocasali? |
brunoocasali
force-pushed
the
remove-esa-version
branch
from
September 24, 2021 12:24
5e6377b
to
7ec90b5
Compare
@BobrImperator could you please accept the workflow execution? |
brunoocasali
force-pushed
the
remove-esa-version
branch
from
September 24, 2021 12:27
7ec90b5
to
324b555
Compare
brunoocasali
force-pushed
the
remove-esa-version
branch
from
September 24, 2021 12:28
324b555
to
15690d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2303
Closes #2309