Update login action with Ember run loops #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Ember run-loops to prevent QUnit hang ups
|
This suggests that the Ember.run should be (if necessary at all) around the call to |
|
That was my first try, but it didn't work. In this guide is also another post, with a solution similar to mine. I think the reason, that the all enclosing run didn't work is the promise. |
marcoow
added a commit
that referenced
this pull request
Dec 2, 2013
Update login action with Ember run loops
|
You're right - it is actually necessary. It's a little hard to get that run loop thing so excuse my ignorance here... This also fixes @tonegarot's problem (#38). |
marcoow
pushed a commit
that referenced
this pull request
Feb 8, 2018
…ry scenario (#39) and use "npm run test:all" instead to test against all scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm currently working on an EmberJS app and I use the emper-simple-auth plug-in. Today I started testing with QUnit and as I tried to test the login action QUnit hang up on that test. I think it's similar to #35, but on another place.
So I added two Ember.run calls to prevent QUnit hang ups.