-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for V2 Addon conversion. #2027
Conversation
f93457a
to
b31217a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Some of the comments I added seem like they can be ignored since I made them before seeing #2028.
For consistency across our other repos, I'd like to ask to put each of the packages to /packages/
directory.
Other than that everything looks perfect 👍
@@ -30,7 +30,9 @@ jobs: | |||
|
|||
- name: auto-dist-tag | |||
run: npx auto-dist-tag@1 --write | |||
working-directory: qunit-dom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the working-directory makes sense to me, so I'd not change that.
Note; Although on another note we should consider setting up scripts for that in the root package.json.
note, I will be discarding all package.json / lockfile changes because having a chain of 3 PRs to manage over a long period of time while upstream is changing so much is hard. (normally this wouldn't be the case, but the repo is getting restructured) However, This PR: #2031 |
5107bf0
to
6c3e59d
Compare
Also, I'm going to start squashing all my commits in each PR. I'm going to undo moving everything in to This allowed me to be able to rebase #2028 |
47df13a
to
9d0b2d0
Compare
…n-place Restore workflows, unchanged Put some documentation config / files back and get 'docs' building working Looks like all of ci.yml should work now Cleanup and get tests passing Add lint:fix script Get lints passing Move renovate config back out to the root release.yml should be up-to-date now as well Restore ember-try config Remove test:ember from the addon, because the test app has been extracted Update ci.yml for compatibility testing Move projects in to packages folder
…structure again -- can happen later
0dad7c4
to
8df721a
Compare
Note the diff stats are way more intimudating than this PR actually is.
It's 90% "moves" + some boilerplate.
Very little has actually changed.
The primary purpose of V2 Addon conversions is to get ember apps installing deps, booting and building faster
(for me, anyway)
qunit-dom has never been compatible with modern packagers -- this is due to the issue reported in #2022 partially due to incorrect package.json config.
Since we want to also be good stewards of the ember ecosystem, we don't want to just fix the issue for non-ember users. We want to make sure that ember users don't pay the v1 addon / broccoli infrastructure cost when consuming this library.
Step one: convert to monorepo
Step two: convert the addon to v2
For additional context on this process, I've written up this guide: https://gist.github.com/NullVoxPopuli/eafc7dad6547de5e730098498b829e1f
1. Convert solo-repo to single-package monorepo
step because I know that the MainMatter folks are more up to date with what's going on in the ember ecosystem than most, and the step is very small anyway.Thankfully, qunit-dom is already using pnpm 🎉