Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package defines an empty module for the convenience of typescript users, so they can say
import "qunit-dom"
to get the types loaded. It's not really needed for any actual code, because the code gets applied directly to QUnit's own objects.But because this package declares itself an ember-addon, its own module namespace is expected to be defined by real modules in
treeForAddon
ortreeForAddonTestSupport
. Not a dynamicdefine
invendor
.define()
is most commonly used for things that aren't in an addon's own module namespace, and that continues to work under embroider. But this more unusual case -- an addondefine()
ing itself -- is not supported.Without this change, attempting to
import "qunit-dom"
fails under embroider.