-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load i2c-dev
modules
#217
Conversation
Hey @ashthespy , First of all thank you for your contribution! Please create this file using the unpack function. If you are interessted in doing it via As soon the build is successful and we tested the resulting image, we will merge your fix and asap release a new version. Regards Kwad |
Have switched to |
Will have a look, need to set up a build environment first.. |
This is quite simple. Enable actions in your develop repo, then it should build an Image for debugging in your PR Branch, if it fails to start automaticly, you could force it to run via workflow_dispatch |
Yeah, looks like using
|
That should now work. pi@mainsailos:~ $ cat /etc/modules
# /etc/modules: kernel modules to load at boot time.
#
# This file contains the names of kernel modules that should be loaded
# at boot time, one per line. Lines beginning with "#" are ignored.
i2c-dev
bcm2835-v4l2
pi@mainsailos:~ $ i2cdetect -y 1
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: -- -- -- -- -- -- -- --
Sorry for the multiple attempts, it took a while to get up to speed with the workflow here :-) Not sure how you feel, but it might be smart to include |
Good point, would you mind to extend your PR? |
This PR adds to mainsail-crew#196 with the required bits to enable i2c by default. - enable `i2c-dev` module - install `i2c-tools` package Signed-off-by: ashthespy <ashthespy@users.noreply.github.com>
Done 👍 |
A test of @meteyou went very well, so, will test that also, but think we can merge it soon. |
My test went also well, so LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds to #196 with the required bits to enable i2c by default.
Fixes: #216
You might also just want to use
raspi-config
's undocumentednoint
mode directly from the chroot script?And then use some sed magic to add the comments from #196 to config.txt.