Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support no_proxy mode with camera-streamer (bookworm) #238

Merged

Conversation

t3chguy
Copy link
Contributor

@t3chguy t3chguy commented Jan 27, 2024

No description provided.

@mryel00
Copy link
Member

mryel00 commented Jan 27, 2024

@t3chguy Thanks for the PR, but please have a look at my comment from #221 there are all the infos you need, before I can consider to merge it.
This is basically a duplicate but I didn't get a response from the OP of that other PR.

@t3chguy t3chguy force-pushed the t3chguy/no_proxy_mode_camera_streamer branch from 126bad5 to 4c5cf32 Compare January 27, 2024 23:45
@t3chguy
Copy link
Contributor Author

t3chguy commented Jan 27, 2024

@mryel00 how about this?

@t3chguy t3chguy force-pushed the t3chguy/no_proxy_mode_camera_streamer branch from 4c5cf32 to ba6299c Compare January 27, 2024 23:47
libs/camera-streamer.sh Outdated Show resolved Hide resolved
libs/camera-streamer.sh Outdated Show resolved Hide resolved
@mryel00
Copy link
Member

mryel00 commented Jan 27, 2024

Seems fine. I will make a sanity test tomorrow to be sure everything is correct.

@t3chguy t3chguy force-pushed the t3chguy/no_proxy_mode_camera_streamer branch from ba6299c to 92c3ccc Compare January 27, 2024 23:55
@t3chguy t3chguy requested a review from mryel00 January 27, 2024 23:55
@t3chguy
Copy link
Contributor Author

t3chguy commented Jan 28, 2024

Actually, looks like one of my printers is running such a version of camera-streamer, and it listens on 0.0.0.0 - so the WARN log is probably not needed.

@mryel00
Copy link
Member

mryel00 commented Jan 28, 2024

Yes they listen on 0.0.0.0 on the old version and you cannot change that.
You are right about the message. As long as it's true that message doesn't make any sense. For false it could make sense, but I don't think it's necessary tbh. So the warning can be deleted.

@t3chguy t3chguy force-pushed the t3chguy/no_proxy_mode_camera_streamer branch from 92c3ccc to 0682c19 Compare January 28, 2024 16:10
@t3chguy
Copy link
Contributor Author

t3chguy commented Jan 28, 2024

@mryel00 Done.

Copy link
Member

@mryel00 mryel00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and this should be the last thing you need to change.
Also don't use force push please. I will squash merge the commit in the end and delete the commit history if it's useless. It just makes it harder for me to pull it if you force push it.

libs/camera-streamer.sh Outdated Show resolved Hide resolved
@mryel00 mryel00 changed the title fix: support no_proxy mode for camera-streamer too fix: support no_proxy mode with camera-streamer (bookworm) Jan 28, 2024
@t3chguy t3chguy requested a review from mryel00 January 28, 2024 21:20
@mryel00 mryel00 merged commit 618d887 into mainsail-crew:develop Jan 28, 2024
1 check passed
@mryel00
Copy link
Member

mryel00 commented Jan 28, 2024

Thank you for the contribution and the fast response time ❤️

@t3chguy t3chguy deleted the t3chguy/no_proxy_mode_camera_streamer branch January 28, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants