Initial work for 2.5 #304
Merged
Initial work for 2.5 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustRootOnly The certificate verifification depth needed to change from 2 to 1 because OpenSSL excludes the root AND leaf certs from the depth check, whereas BoringSSL only excludes the leaf cert. Signed-off-by: Ted Poole <tpoole@redhat.com>
Build is enabled in CI but tests are not.
jwendell
added
the
tide/merge-method-rebase
|
|
@yxun the tests passed but the job failed at some post action. Can you please take a look? |
What are that set of Github CI jobs ? It looks like in the ci directory. They are triggered by Github or bot |
|
"Process did not finish before 10m0s timeout" we have some timeout limit in cleanup step. The namespace deletion was stuck. Actually, we don't need that step. The deprovision cluster step is enough for cleanup. |
|
/retest |
1 similar comment
|
/retest |
openshift-merge-bot
bot
merged commit 3181c70
into
maistra:maistra-2.5
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Dario's branch, plus one commit with a few adjustments to CI scripts and removal of some leftover files from rebase.