Remove /^I should get a text response$/ which is only an alias
#135
Comments
|
Can you even see the content-type in a Selenium test? |
|
To avoid unnecessary version bumps (and confusion) we should approach all "remove xy" issues at once. Also, before removing, we want to release a version x.99 which prints deprecation warnings for everything that is removed in version x+1. |
nhasselmeyer
added a commit
that referenced
this issue
Oct 1, 2020
- The following steps have been removed: - `/^the file "([^"]*)" was attached(?: as (?:([^"]*)\/)?([^"]*))? to the ([^"]*) above(?: at "([^"]*)")?$/` (see [#106](#106)) - `/^the "([^"]*)" field should have no error$/` (see [#134](#134)) - `/^I should get a text response$/` (see [#135](#135)) - `/^I wait for the page to load$/` (see [#136](#136)) - `debugger` (was an alias for `console`) - `/^(an|no) e?mail should have been sent((?: |and|with|from "[^"]+"|bcc "[^"]+"|cc "[^"]+"|to "[^"]+"|the subject "[^"]+"|the body "[^"]+"|the attachments "[^"]+")+)$/`, `/^that e?mail should( not)? have the following lines in the body$/` and `/^that e?mail should have the following (?:|content in the )body:$/` (see [#132](#132 (comment))) - The step `/^(the tag )?"([^\"]+)" should( not)? be visible$/` lost its `not` modifier (Use `Then (the tag )?"..." should be hidden` or `Then I should not see "..."`) - The file `lib/spreewald/timecop_steps.rb` was removed (was an alias for `lib/spreewald/time_steps.rb`).
nhasselmeyer
added a commit
that referenced
this issue
Oct 1, 2020
- The following steps have been removed: - `/^the file "([^"]*)" was attached(?: as (?:([^"]*)\/)?([^"]*))? to the ([^"]*) above(?: at "([^"]*)")?$/` (see [#106](#106)) - `/^the "([^"]*)" field should have no error$/` (see [#134](#134)) - `/^I should get a text response$/` (see [#135](#135)) - `/^I wait for the page to load$/` (see [#136](#136)) - `debugger` (was an alias for `console`) - `/^(an|no) e?mail should have been sent((?: |and|with|from "[^"]+"|bcc "[^"]+"|cc "[^"]+"|to "[^"]+"|the subject "[^"]+"|the body "[^"]+"|the attachments "[^"]+")+)$/`, `/^that e?mail should( not)? have the following lines in the body$/` and `/^that e?mail should have the following (?:|content in the )body:$/` (see [#132](#132 (comment))) - The step `/^(the tag )?"([^\"]+)" should( not)? be visible$/` lost its `not` modifier (Use `Then (the tag )?"..." should be hidden` or `Then I should not see "..."`) - The file `lib/spreewald/timecop_steps.rb` was removed (was an alias for `lib/spreewald/time_steps.rb`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The step just calls the
I should get a response with content-type "text/plain"step.I would prefer not to have many aliases in Spreewald. Of course if there is a very complex step that most of the time needs to be used in one simple way an alias may make sense, but this one is very simple.
👍 to vote for deprecating and removing this step
👎 to vote for keeping
The text was updated successfully, but these errors were encountered: