Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"an email should have been sent with" step behaves incorrectly when not specifying headers #157

Closed
foobear opened this issue Nov 25, 2020 · 1 comment

Comments

@foobear
Copy link
Member

foobear commented Nov 25, 2020

The an email should have been sent with: step always considers everything until the first \n\n to be headers. It ignores any lines that do not match the header style, so when given only a message body, it ignores anything until the first \n\n.

Example:

Then an email should have been sent with:
  """
  Hello
  
  Bye
  """

This passes for an email where the body is only "Bye".

I suggest raising an error when encountering an invalid header line, or considering the entire string as the message body, if the headers section does not contain header-link lines.

FLeinzi added a commit that referenced this issue Dec 16, 2020
…t with" step behaves incorrectly when not specifying headers
@FLeinzi
Copy link
Contributor

FLeinzi commented Dec 16, 2020

I made a pull request for this issue: #158

We will now interpret all lines as body when not specifying headers.

@FLeinzi FLeinzi closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants