-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thermoval TVT 40 WiFi Thermostat #1421
base: main
Are you sure you want to change the base?
Conversation
name: fault | ||
type: integer | ||
- id: 5 | ||
name: room_temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be current_temperature to make it available through the climate card.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to make this conditionally redirect to floor_temperature when sensor_select is "0", the config will be more complex, but the UI might make more sense in terms of offset between the set temperature and current temperature. If you do this, then keep the room temperature separate sensor, so that it is always available regardless of the sensor select setting.
icon: "mdi:hand-back-right-off" | ||
- dps_val: false | ||
icon: "mdi:hand-back-right" | ||
- entity: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicates of what is already covered in the climate entity (temperature, current_temperature, preset_mode, hvac_mode, hvac_action) should not be added as secondary entities.
value: manual | ||
icon: "mdi:cursor-pointer" | ||
- id: 4 | ||
name: fault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this fault_code, and add a binary_sensor for it as well, that maps 0 to false, and any other value to true. The binary sensor should be more convenient to use in automations and for an indication in the UI that there is a fault, and the attribute here gives access to the full fault code for reference.
type: integer | ||
mapping: | ||
- scale: 10 | ||
- id: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attributes that are not used in the climate platform, and have separate entities under secondary_entities should not be listed here. Basically the attributes listed under climate should fall under one of the following:
- standard attributes of the climate platform
- attributes that are used in conditions to create advanced behavior
- read-only attributes that do not make sense as separate entities on their own
- id: 9 | ||
name: hvac_mode | ||
type: boolean | ||
readonly: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hvac_mode should not be read-only. If this is really read-only, rename this attribute (I guess the original tuya name is work_mode, which would be appropriate) to avoid buttons that cannot be used in the UI (the mode will then always show as auto).
@make-all Thanks for review! It's been six months since I created this configuration, I've forgotten a lot. 🤯 Anyway, it's based on another device's configuration that someone provided somewhere as a workaround, but I can't find that entry. The replacement worked fine with the basic functionality of the thermostat. Thermostate cards do not support such a combo, I'm fine with apexchart: |
Home: https://thermoval.pl/en/contact-en/
Catalog: https://thermoval.pl/wp-content/uploads/2023/09/THERMOVAL-Cennik-ENG.pdf
Screenshots:
![obraz](https://private-user-images.githubusercontent.com/50808402/291027461-754a438e-c4c9-4201-b2b8-0bddaa2fdc15.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNTk3MjAsIm5iZiI6MTcyNDA1OTQyMCwicGF0aCI6Ii81MDgwODQwMi8yOTEwMjc0NjEtNzU0YTQzOGUtYzRjOS00MjAxLWIyYjgtMGJkZGFhMmZkYzE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDA5MjM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY4MGUyZTNiNzYxOTE2YmVjNTQ4ZTc3Y2U3NzE2MDdlNDViMDIxOWM3NDBiZWY4YTg5ZDMzZmEyYTkwZTAzY2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kGEeROCE75a3lul7USaU2SBQ94A3q2Rhw8_Qwnx1DSY)
![obraz](https://private-user-images.githubusercontent.com/50808402/291027360-d5e7af49-0fa5-4aec-a126-5e81fb5957b5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNTk3MjAsIm5iZiI6MTcyNDA1OTQyMCwicGF0aCI6Ii81MDgwODQwMi8yOTEwMjczNjAtZDVlN2FmNDktMGZhNS00YWVjLWExMjYtNWU4MWZiNTk1N2I1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDA5MjM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1MzExZGM2NjRjOGFkMTM2ZjRlMWFkYzJlNDczYjYxMzBlNjQ4OTAyZjNmZDFhZWNhZWI4ZTgwNjRmZTk0MTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tpvIoOiNh5pImujMvEnL58MpJb-Fei3pjG-NNpCIM_A)
![obraz](https://private-user-images.githubusercontent.com/50808402/291027365-be4184d4-d401-4c54-9c3d-dd3bbc6bae89.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNTk3MjAsIm5iZiI6MTcyNDA1OTQyMCwicGF0aCI6Ii81MDgwODQwMi8yOTEwMjczNjUtYmU0MTg0ZDQtZDQwMS00YzU0LTljM2QtZGQzYmJjNmJhZTg5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDA5MjM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiM2Y3NzAwYWI0MDlhMmRjOGM1NjRkMGI4MTJkY2Y5NTIxZTEzZDU1NmU2MmNjYjA0MTQxZTdhMjk2ZGFjNjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cSWKry-NGbT1UZ5VH6wB2eU5mZZ5pjt5ejliX9Y4ny0)
![obraz](https://private-user-images.githubusercontent.com/50808402/291027366-25cc90af-2cf1-45db-8120-6b4d4eaea9d5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNTk3MjAsIm5iZiI6MTcyNDA1OTQyMCwicGF0aCI6Ii81MDgwODQwMi8yOTEwMjczNjYtMjVjYzkwYWYtMmNmMS00NWRiLTgxMjAtNmI0ZDRlYWVhOWQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDA5MjM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmODNjMDAzMjIxMzQ0ZmM5ODg5YWMyYzkxNjM4YjhlNmVlZjI0YzQxNzg1OWU0MTc4YjIwNTlkOWYyMzU1YzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XcdVRiV27DS20aXHsbNslLe-fg40A1CAtaGoGRSGtFg)
![obraz](https://private-user-images.githubusercontent.com/50808402/291027486-8b602847-352c-47a7-a0d5-1ca02bb81c26.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNTk3MjAsIm5iZiI6MTcyNDA1OTQyMCwicGF0aCI6Ii81MDgwODQwMi8yOTEwMjc0ODYtOGI2MDI4NDctMzUyYy00N2E3LWEwZDUtMWNhMDJiYjgxYzI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDA5MjM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkOTFkMjZjNjhlZWQ3ODhkYTEzYmMyMDMxMTllNDNkMmQ3YTEyOGE3Y2EyNDcyODg3MzRiODFiZThhYjJlMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.aZnX3K0pddprGaXjBGZR9jIvptMk0HqQzgyWrBjg8DE)