-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generic gas CO meter #1558
base: main
Are you sure you want to change the base?
Conversation
primary_entity: | ||
entity: sensor | ||
class: carbon_dioxide | ||
name: Sensor Reading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the name, so that translations for carbon dioxide sensor are used.
name: Sensor Reading | ||
dps: | ||
- id: 5 | ||
type: float |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really float? Most Tuya devices are using integer, and then apply a scale factor to get fixed point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need confirmation on this to proceed to merge
@@ -0,0 +1,12 @@ | |||
name: TUYA Gas Leak Detector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top level name should be generic, like "Gas leak detector"
@@ -0,0 +1,12 @@ | |||
name: TUYA Gas Leak Detector | |||
products: | |||
- name: TUYA Gas Leak Detector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Products list must have id for each product, otherwise it will not be able to detect which is which.
Branding in name should be actual brand and model, I think Tuya is not selling any end products themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Product ids can be obtained by scanning your network with tinytuya if you do not have access to the iot.tuya.com portal to get the info from the cloud.
- name: TUYA Gas Leak Detector | ||
primary_entity: | ||
entity: sensor | ||
class: carbon_dioxide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title says CO. Is it carbon_monoxide, or carbon_dioxide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need confirmation on this to proceed to merge.
No description provided.