-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Madimack Elite V3 Pool heatpump with updated dps mappings #1691
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c7e4125
Add files via upload
jameskoziol bc39f64
Merge branch 'main' into main
make-all 3506a39
Merge branch 'main' into main
make-all 254d5d7
Update icons.json
jameskoziol 847c3e5
Update icons.json
jameskoziol 877b6aa
Update madimack_elite_v3_heatpump_updated.yaml
jameskoziol c23f6e2
Update icons.json
jameskoziol b6c60d2
Update icons.json
jameskoziol 62c7db4
Update icons.json
jameskoziol 8acc8b1
Merge branch 'main' into main
make-all ccf3ef1
Revert icons.json
jameskoziol 03ed3f1
Update madimack_elite_v3_heatpump_updated.yaml
jameskoziol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
200 changes: 200 additions & 0 deletions
200
custom_components/tuya_local/devices/madimack_elite_v3_heatpump_updated.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,200 @@ | ||
| name: Madimack Elite V3 pool heatpump | ||
| primary_entity: | ||
| entity: climate | ||
| dps: | ||
| - id: 101 | ||
| name: hvac_mode | ||
| type: boolean | ||
| mapping: | ||
| - dps_val: false | ||
| value: "off" | ||
| icon: "mdi:hvac-off" | ||
| - dps_val: true | ||
| constraint: mode | ||
| conditions: | ||
| - dps_val: auto | ||
| icon: "mdi:refresh-auto" | ||
| value: auto | ||
| - dps_val: cold | ||
| icon: "mdi:snowflake" | ||
| value: cool | ||
| - dps_val: heating | ||
| icon: "mdi:hot-tub" | ||
| value: heat | ||
| - id: 102 | ||
| name: mode | ||
| type: string | ||
| hidden: true | ||
| - id: 104 | ||
| name: temperature | ||
| type: integer | ||
| mapping: | ||
| - constraint: temperature_unit | ||
| conditions: | ||
| - dps_val: f | ||
| range: | ||
| min: 60 | ||
| max: 104 | ||
| range: | ||
| min: 18 | ||
| max: 40 | ||
| # ^ in reality, the range is different for cool and auto | ||
make-all marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - id: 105 | ||
| name: preset_mode | ||
| type: string | ||
| mapping: | ||
| - dps_val: silence | ||
| icon: "mdi:weather-night" | ||
make-all marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| value: sleep | ||
| - dps_val: perfect | ||
| icon: "mdi:weather-sunny" | ||
| value: comfort | ||
| - dps_val: power | ||
| icon: "mdi:sun-thermometer" | ||
| value: boost | ||
| - id: 106 | ||
| name: temperature_unit | ||
make-all marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - id: 110 | ||
| type: integer | ||
| name: max_temperature | ||
| - id: 111 | ||
| type: integer | ||
| name: min_temperature | ||
| - id: 117 | ||
| name: current_temperature | ||
| type: integer | ||
| secondary_entities: | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: Power level | ||
| class: power_factor | ||
| dps: | ||
| - id: 109 | ||
| type: integer | ||
| name: sensor | ||
| unit: "%" | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: External coil temperature | ||
| class: temperature | ||
| dps: | ||
| - id: 112 | ||
| type: integer | ||
| name: sensor | ||
| - id: 106 | ||
| name: unit | ||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: Exhaust temperature | ||
| class: temperature | ||
| dps: | ||
| - id: 113 | ||
| name: sensor | ||
| type: integer | ||
| - id: 106 | ||
| name: unit | ||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: Outlet water temperature | ||
| class: temperature | ||
| dps: | ||
| - id: 114 | ||
| name: sensor | ||
| type: integer | ||
| - id: 106 | ||
| name: unit | ||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: Ambient temperature | ||
| class: temperature | ||
| dps: | ||
| - id: 115 | ||
| name: sensor | ||
| type: integer | ||
| - id: 106 | ||
| name: unit | ||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: Return air temperature | ||
| class: temperature | ||
| dps: | ||
| - id: 118 | ||
| name: sensor | ||
| type: integer | ||
| - id: 106 | ||
| name: unit | ||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: Inner coil temperature | ||
| class: temperature | ||
| dps: | ||
| - id: 119 | ||
| name: sensor | ||
| type: integer | ||
| - id: 106 | ||
| name: unit | ||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: Cooling plate temperature | ||
| class: temperature | ||
| dps: | ||
| - id: 120 | ||
| name: sensor | ||
| type: integer | ||
| - id: 106 | ||
| name: unit | ||
| type: string | ||
| mapping: | ||
| - dps_val: f | ||
| value: F | ||
| - dps_val: c | ||
| value: C | ||
| - entity: sensor | ||
| category: diagnostic | ||
| name: EEV opening | ||
| dps: | ||
| - id: 121 | ||
| name: sensor | ||
| type: integer | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this config should have a
productssection listing theidand branding part of thename, and this top level name should just be the generic part: "Pool heatpump".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can find the product ID through the tuya platform and change. However, I have noticed the product ID code found is identical to another device by the same manufacturer already in your system (madimack_eco_heatpump.yaml). Will using the same product ID code for a different unit be a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine when I eventually use this, it will be capable of showing a list, the same as the dps matching that is currently used (and will continue to be used as a backup). But if the product ids are the same, maybe the config is also compatible (maybe only partially specified, as the knowledge of where to get good info from to make a complete config has evolved over time).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a product ID line and the specific name of the unit I am using to my fork. I'm also a github newbie so let me know if you cannot see this.
As mentioned before - there may be an issue in that the product ID appears to be duplicated with other completely separate products made by the same manufacturer