add support Smart curtain robot Dongguan LY1678-2 #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Mar 3, 2024
custom_components/tuya_local/devices/dongguan_electric_curtain.yaml
Outdated
Show resolved
Hide resolved
- Avoid use of superfluous terms like "Smart" in device names - Name under products just needs to identify manufacturer and model, the top level name already describes the general purpose of the device - no need to name the cover entity, as the class defines a translated name already. PR make-all#1698
make-all
added a commit
that referenced
this pull request
Mar 3, 2024
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
- Avoid use of superfluous terms like "Smart" in device names - Name under products just needs to identify manufacturer and model, the top level name already describes the general purpose of the device - no need to name the cover entity, as the class defines a translated name already. PR make-all#1698
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.