Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Plikc Neve X W thermostat #1878

Merged
merged 4 commits into from
May 25, 2024
Merged

Add support for Plikc Neve X W thermostat #1878

merged 4 commits into from
May 25, 2024

Conversation

beltra
Copy link
Contributor

@beltra beltra commented May 4, 2024

Add support for Plikc Neve X W thermostat.
Quite similar to Plikc Neve X WRF, but some issues of that integration have been fixed. Supports setting automatic, manual and holiday mode. Heating is correctly displayed when active.

Copy link
Owner

@make-all make-all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general device and entity names should be in English, as there is a high chance of any config also matching devices sold in other markets, and for better or worse, English is the most widely spoken.

You are welcome though to contribute to #1708 by expanding translation_keys to cover more common entity types.

- use English names
- remove misplaced 'force'
- user needs to set vacation duration to enter away mode
- use unspecified degrees for relative temperature to avoid conversion
@make-all make-all merged commit 3f50d77 into make-all:main May 25, 2024
4 checks passed
make-all added a commit that referenced this pull request May 25, 2024
There seems to be an overlap between PR and issue, and due to
an unanswered question on the PR, the issue got handled first.  So
these were duplicated.

Merge in the heat/cool support (original was cool only), and other
changes from PR #1878
@beltra
Copy link
Contributor Author

beltra commented May 27, 2024

Thanks for the changes, sorry I didn't have time to fix the problems. I'd suggest changing the dps_val for id 1 to heat as the device only supports heating.

@make-all
Copy link
Owner

The hvac_action values include both heating and cooling. Is that a mistake?

@beltra
Copy link
Contributor Author

beltra commented May 27, 2024

The thermostat can operate in only one mode at a time and a reset is required to change mode (i.e. it has only one physical output to turn on/off only one device). I don't know if an option can be added in the integration to set the behaviour.

timlaing pushed a commit to timlaing/tuya-local that referenced this pull request Aug 8, 2024
There seems to be an overlap between PR and issue, and due to
an unanswered question on the PR, the issue got handled first.  So
these were duplicated.

Merge in the heat/cool support (original was cool only), and other
changes from PR make-all#1878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants