feat(fan): added support for gorilla fan v2 #1988
Conversation
| @@ -0,0 +1,58 @@ | |||
| name: Gorilla Fan V2 | |||
There was a problem hiding this comment.
Preferably there should be a products section here, with product id and name (with branding), and the top level name should be generic (Ceiling fan, for example)
There was a problem hiding this comment.
I see from #1971 that the brand is Atomberg, and the product name is Gorilla. The file naming and the name in the products section should reflect this. I'm not sure whether the V2 is part of the product name, or it is a misunderstanding that whatever config you originally installed this as is "V1" (but there is no atomberg or gorilla config, so there is no need to use v2 here as disambiguation if it is not part of the actual product name).
There was a problem hiding this comment.
The fan in question is from Atomberg and is referred to as the Renesa fan. However, this name is not present in any of our systems. In both the Tuya Dashboard and the Smart Life App, it is listed as the Gorilla Fan V2. Therefore, I used this name for consistency.
There was a problem hiding this comment.
What about the product id? If you cannot get it from the cloud, it is also possible to read from python -m tinytuya scan
|
@make-all The configurations are updated as per your recommendations. Please review my comments and changes. |
Preference is to keep branding under products. Since no product id has been informed, add as a comment
Add support for Gorilla Fan V2
This PR adds support for the Gorilla Fan V2 device to the Tuya Local integration.
Changes
gorilla_fan_v2.yamldefining the DPS mappings and entities for the Gorilla Fan V2Testing
Resolves: #1971