v0.3.0 Proposal #28
Closed
v0.3.0 Proposal #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the pretest script provided by npm just run the script before test. Looks like npm just execute the pretest script but doesn't care whether it fails or not. Fixed by having `npm run eslint` before `npm run utest` in `test` script
style.css shouldn't be in public folder since gulp will build public/style.css to be in css/style.min.css. How did it get here anyway
application port: PORT port for development: PORT_DEV PORT_DEV will take effect when run gulp browser-sync. Meaning that PORT_DEV will take effect when run `npm run dev` too.
in case of cdn goes down or develop offline font-awesome will be load locally from /css/font-awesome.min.css
Fallback support for font awesome
For consistent coding style across multiple IDEs http://editorconfig.org/
The one that is chained with other promise. To resolve promise warnings
…ening again By run `npm prune` before installation, it will remove unused dependencies that does not appear in package.json
* remove express session Unused dependencies * read environment variable without node foreman * default port for app in dev (devPort=3000, appPort=5000) * add pm2 configuration file * configure docker to start modcolle with pm2 * fix #8 'request error' sent from OSAPI Environment variables loaded in KEY=VALUE format is the cause of this problem. Fixed by loading environment variables in JSON format by using dot-env library. * automatically prepare environment variables file using gulp .env.json will not be overwritten if the file already exists * update README.md
* gulp: watch for html changes in public/ folder * index.hbs as public/index.html * remove default layout and put in Kancolle template
* run test coverage with nyc * ignore gulpfile.js from test coverage No need to test development file
* bigger launcher button * replace swinging animations with scale animation
* chore(package): update dependencies * update sinon to only v1.17.7 * ignore checking update sinon for now
* update sinon v2.1.0 * adapt testcases to new sinon API * remove sinon from gatekeeper package ignore list
makemek
added a commit
that referenced
this pull request
Apr 23, 2017
* Frontend - Fallback support for font-awesome. Load font-awesome from their CDN. If fails, load them from the server - CSS and JS are now minified and uglified on build - Bigger launcher button - In development mode, sync css and js automaticaaly on file changes to browser * Can be launched using PM2 * Incorporate new sinon v2 API changes * index.html rendered statically PR-URL: #28
makemek
added a commit
that referenced
this pull request
Apr 23, 2017
* Frontend - Fallback support for font-awesome - CSS and JS are now minified and uglified on build - Bigger launcher button - In development mode, sync css and js automaticaaly on file changes to browser * Can be launched using PM2 * Incorporate new sinon v2 API changes * index.html rendered statically PR-URL: #28
makemek
added a commit
that referenced
this pull request
Apr 23, 2017
Notable Changes: * Frontend - Fallback support for font-awesome - CSS and JS are now minified and uglified on build - Bigger launcher button - In development mode, sync css and js automaticaaly on file changes to browser * Can be launched using PM2 * Incorporate new sinon v2 API changes * index.html rendered statically PR-URL: #28
makemek
added a commit
that referenced
this pull request
Apr 23, 2017
Notable Changes: * Frontend - Fallback support for font-awesome - CSS and JS are now minified and uglified on build - Bigger launcher button - In development mode, sync css and js automaticaaly on file changes to browser * Can be launched using PM2 * Incorporate new sinon v2 API changes * index.html rendered statically PR-URL: #28
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Notable Changes: * Frontend - Fallback support for font-awesome - CSS and JS are now minified and uglified on build - Bigger launcher button - In development mode, sync css and js automaticaaly on file changes to browser * Can be launched using PM2 * Incorporate new sinon v2 API changes * index.html rendered statically PR-URL: #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017.04.23, Version 0.3.0
Notable Changes
index.htmlrendered staticallyCommits
02ded80] Update test code to new sinon v2 API (Update test code to new sinon v2 API #18)91087c4] Update dependencies to enable Greenkeeper (Update dependencies to enable Greenkeeper 🌴 #17)648aba2] reuse eslint config from modcolle-eslint-config (Extends Modcolle's eslint config from eslint-config-modcolle repo #15)cb07980] Bigger and smoother launcher button (Bigger and smoother launcher button #14)0c7248a] Run test coverage with nyc (Run test coverage with nyc #12)b5b1db7] remove 'npm prune' from preinstall script (remove 'npm prune' from preinstall script #13)89d10a9] fix http 502 when aquiring kc assets3dc59b6] index.html as a static page (index.html as a static page #11)ca8bd10] gitignore only fonts and minified css/js (gitignore only fonts and minified css/js #10)fb825f6] Daemonized Modcolle with PM2 (Daemonized Modcolle with PM2 #7)8352973] fix missing dependencies when run gulp build and prevent it from happening againca46350] make sure to return promises21f49bb] add .editorconfig file to enforce indentation and line ending1acc0c8] Merge pull request Fallback support for font awesome #6 from makemek/fallback-font-awesomec2ebbbe] babel, uglify, and eslint fallback supportcb2e7fe] fallback support for font-awesome564729f] import font-awesome to public assets on builddec2db2] configurable port for app and developmenteaeedbd] offload font-awesome to cdnc4cfe0a] require css/style.min.css instead of style.css5be85d5] gulp build at prestart and pretest38ba7bd] automatically sync .css and .hbs to browser when modifieda9c471f] automatically autoprefix and minify css in src/views/*.css7dba9b8] fix eslint test fail but doesn't trigger failure1c9b8d3] forget to remove semicolon to pass eslint