Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow wider paramter types for type guards and add type guards for RichTextItemResponse. #469

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Allow wider paramter types for type guards and add type guards for RichTextItemResponse. #469

merged 2 commits into from
Oct 26, 2023

Conversation

rhart92
Copy link
Contributor

@rhart92 rhart92 commented Oct 26, 2023 •
edited
Loading

Fixes #468 now that type guard types are wider.

Fixes #448 by adding type guards for RichTextItemResponse.

@rhart92 rhart92 changed the title Allow wider paramter types for type guards Allow wider paramter types for type guards and add type guards for RichTextItemResponse. Oct 26, 2023
@rhart92 rhart92 changed the title Allow wider paramter types for type guards and add type guards for RichTextItemResponse. Allow wider paramter types for type guards and add type guards for RichTextItemResponse. Oct 26, 2023
kiranpandit
kiranpandit approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@kiranpandit kiranpandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rhart92 rhart92 merged commit ba87338 into main Oct 26, 2023
4 checks passed
@rhart92 rhart92 deleted the ryan--type-guards-parameters-should-be-wider branch October 26, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranpandit kiranpandit kiranpandit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map over database results union type Addition of Type Guards for RichTextItemResponse
2 participants
@rhart92 @kiranpandit