Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of Fixes #796

Merged
merged 10 commits into from
Apr 22, 2024
Merged

Bunch of Fixes #796

merged 10 commits into from
Apr 22, 2024

Conversation

brendancol
Copy link
Contributor

@brendancol brendancol commented Apr 14, 2024

The following PR includes a bunch of fixes that I need to get CI/CD working again.

The most technically unstable is an update to experimental/polygonize.py which now has a custom implementation of generated_jit, but should in the future use nb.extends.overload style...

I also:

  • got codecov working again
  • added Python 3.12 support to CI/CD
  • dropped 3.8 / 3.9 support from CI/CD

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.04%. Comparing base (27ab0c8) to head (a83bf9b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   79.94%   80.04%   +0.10%     
==========================================
  Files          19       19              
  Lines        4178     4179       +1     
==========================================
+ Hits         3340     3345       +5     
+ Misses        838      834       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brendancol brendancol requested a review from tcmetzger April 22, 2024 20:45
@brendancol brendancol self-assigned this Apr 22, 2024
@brendancol brendancol added bug Something isn't working enhancement New feature or request labels Apr 22, 2024
@brendancol brendancol changed the title Updated Year in Citation Bunch of Fixes Apr 22, 2024
Copy link
Collaborator

@tcmetzger tcmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tcmetzger tcmetzger merged commit 950ca44 into master Apr 22, 2024
11 checks passed
@tcmetzger tcmetzger deleted the update-citation-year branch April 22, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants