Dropped version info from docker-compose files #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docker issue 11628 (docker/compose#11628) the 'version' field in docker-compose files is outdated. It shows a warning like the following on hosts with a newer Docker version: ``` WARN[0000] /srv/plane/docker-compose.yaml: `version` is obsolete ``` Also, the specs itself state the version was only informative: https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elements > The top-level `version` property is defined by the Compose > Specification for backward compatibility. It is only informative. > Compose doesn't use version to select an exact schema to > validate the Compose file, but prefers the most recent schema > when it's implemented.
|
|
mguptahub
approved these changes
Apr 1, 2024
|
@CrsiX Please sign the CLA before we can approve to merge |
|
I've signed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docker compose issue 11628 (docker/compose#11628) the 'version' field in docker-compose files is outdated. It shows a warning like the following on hosts with a newer Docker version:
Also, the specs itself state the version was only informative: https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elements