-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-5] fix: PWA sticky issue comment #5419
Conversation
WalkthroughThe changes involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant IssueCommentCreate
participant useIssueDetail
participant common.helper
User->>IssueCommentCreate: Render component
IssueCommentCreate->>useIssueDetail: Retrieve peekIssue
useIssueDetail-->>IssueCommentCreate: Return peekIssue value
IssueCommentCreate->>common.helper: Apply CSS class based on peekIssue
IssueCommentCreate-->>User: Display styled component
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/components/issues/issue-detail/issue-activity/comments/comment-create.tsx (3 hunks)
Additional comments not posted (4)
web/core/components/issues/issue-detail/issue-activity/comments/comment-create.tsx (4)
10-10
: Import ofcn
function looks good.The import statement for the
cn
function is correctly added fromcommon.helper
.
13-13
: Import ofuseIssueDetail
hook looks good.The import statement for the
useIssueDetail
hook is correctly added fromstore
hooks.
31-31
: Usage ofpeekIssue
looks good.The
peekIssue
variable is correctly used to conditionally apply CSS classes, enhancing the component's responsiveness.
63-65
: Conditional class application looks good.The
cn
function is used effectively to conditionally apply the-bottom-5
class based on thepeekIssue
state.
Changes:
This PR includes following changes:
Reference:
[PWA-5]
Summary by CodeRabbit
New Features
Bug Fixes