-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PULSE-42] feat: text alignment for all editors #5847
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e2bcf25
feat: text alignment for editors
aaryan610 5eaf9fd
fix: text alignment types
aaryan610 7d7cbff
fix: build errors
aaryan610 b05f407
fix: merge conflicts resolved from preview
aaryan610 e4cb32e
fix: build error
aaryan610 32cbc56
fix: toolbar movement post alignment selection
aaryan610 66b8049
fix: merge conflicts resolved from preview
aaryan610 7763569
fix: callout type
aaryan610 3e8dc95
fix: image node types
aaryan610 e2a2812
chore: add ts error warning
aaryan610 e560038
fix: merge conflicts resolved from preview
aaryan610 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
packages/editor/src/core/components/menus/bubble-menu/alignment-selector.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
import { Editor } from "@tiptap/core"; | ||
import { AlignCenter, AlignLeft, AlignRight, LucideIcon } from "lucide-react"; | ||
// components | ||
import { TextAlignItem } from "@/components/menus"; | ||
// helpers | ||
import { cn } from "@/helpers/common"; | ||
// types | ||
import { TEditorCommands } from "@/types"; | ||
|
||
type Props = { | ||
editor: Editor; | ||
}; | ||
|
||
export const TextAlignmentSelector: React.FC<Props> = (props) => { | ||
const { editor } = props; | ||
|
||
const menuItem = TextAlignItem(editor); | ||
|
||
const textAlignmentOptions: { | ||
itemKey: TEditorCommands; | ||
renderKey: string; | ||
icon: LucideIcon; | ||
command: () => void; | ||
isActive: () => boolean; | ||
}[] = [ | ||
{ | ||
itemKey: "text-align", | ||
renderKey: "text-align-left", | ||
icon: AlignLeft, | ||
command: () => | ||
menuItem.command({ | ||
alignment: "left", | ||
}), | ||
isActive: () => | ||
menuItem.isActive({ | ||
alignment: "left", | ||
}), | ||
}, | ||
{ | ||
itemKey: "text-align", | ||
renderKey: "text-align-center", | ||
icon: AlignCenter, | ||
command: () => | ||
menuItem.command({ | ||
alignment: "center", | ||
}), | ||
isActive: () => | ||
menuItem.isActive({ | ||
alignment: "center", | ||
}), | ||
}, | ||
{ | ||
itemKey: "text-align", | ||
renderKey: "text-align-right", | ||
icon: AlignRight, | ||
command: () => | ||
menuItem.command({ | ||
alignment: "right", | ||
}), | ||
isActive: () => | ||
menuItem.isActive({ | ||
alignment: "right", | ||
}), | ||
}, | ||
]; | ||
|
||
return ( | ||
<div className="flex gap-0.5 px-2"> | ||
{textAlignmentOptions.map((item) => ( | ||
<button | ||
key={item.renderKey} | ||
type="button" | ||
onClick={(e) => { | ||
item.command(); | ||
e.stopPropagation(); | ||
}} | ||
className={cn( | ||
"size-7 grid place-items-center rounded text-custom-text-300 hover:bg-custom-background-80 active:bg-custom-background-80 transition-colors", | ||
{ | ||
"bg-custom-background-80 text-custom-text-100": item.isActive(), | ||
} | ||
)} | ||
> | ||
<item.icon className="size-4" /> | ||
</button> | ||
))} | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider refactoring 'textAlignmentOptions' to reduce code duplication
To improve maintainability and readability, you can generate
textAlignmentOptions
by mapping over an array of alignment configurations. This approach minimizes repetition and makes it easier to add or modify alignment options in the future.Apply this diff to refactor the code:
📝 Committable suggestion