Fixed slow allowed users query due to use of regex. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmarz
reviewed
Nov 8, 2021
| $allowedUserIds = implode(',', $wpdb->get_col( | ||
| $wpdb->prepare("SELECT u.ID FROM {$wpdb->prefix}users u WHERE u.user_email REGEXP ('%s')", implode('|', $allowedEmails) | ||
| ))); | ||
| $wpdb->prepare("SELECT u.ID FROM {$wpdb->prefix}users u WHERE u.user_email IN ({$emailsPlaceholder})", $allowedEmails) |
There was a problem hiding this comment.
Looks good to me, but why did you use {$wpdb->prefix}users instead of {$wpdb->users}? 🤔
Suggested change
| $wpdb->prepare("SELECT u.ID FROM {$wpdb->prefix}users u WHERE u.user_email IN ({$emailsPlaceholder})", $allowedEmails) | |
| $wpdb->prepare("SELECT u.ID FROM {$wpdb->users} u WHERE u.user_email IN ({$emailsPlaceholder})", $allowedEmails) |
There was a problem hiding this comment.
@fabianmarz only for the sake of consistency, since tables like woocommerce_order_items are not available like that.
fabianmarz
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
regexp, it looks like this was slowing the query by ~ 0.5-1 secBefore
After