Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): listbox accidentally nested inside of another listbox #169

Merged
merged 1 commit into from
May 7, 2024

Conversation

patricknelson
Copy link
Member

Fixes this issue below at https://makeup.github.io/makeup-js/ui/makeup-listbox-button/index.html.

Essentially, the Unselected, Floating label box was nested inside of the Selected box in the Manual Selection section. Say that 10 times fast.

image

@patricknelson
Copy link
Member Author

@ianmcburnie any clue what's causing this? Tried rerunning but no dice.

image

@patricknelson
Copy link
Member Author

@ianmcburnie thanks for approving. Is it ok to merge this? See above.

@ianmcburnie ianmcburnie merged commit f320d69 into master May 7, 2024
1 check failed
@patricknelson patricknelson deleted the docs-fix-listbox-button branch May 7, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants