Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Local Gemini Files #103

Closed
ghost opened this issue Oct 25, 2020 · 2 comments · Fixed by #117
Closed

Open Local Gemini Files #103

ghost opened this issue Oct 25, 2020 · 2 comments · Fixed by #117
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Oct 25, 2020

Opening a .gmi or .gemini file that is stored locally does not seem to be implemented. It would be a nice feature to be able to view a document as you write it.
@makew0rld makew0rld added the enhancement New feature or request label Oct 25, 2020
@makew0rld
Copy link
Owner

I agree! I think to keep things simple, I would only like to handle files that end in .gmi, .gemini and .txt, as we don't have access to MIME type information like we do over Gemini. The scheme would be file:// like it is for regular browsers, and there would have to be a simple folder view as well, that would maybe only show the files it could open, and subfolders.

I would accept a PR for this, or will get to it at some point.

@makew0rld makew0rld added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 29, 2020
@makew0rld makew0rld mentioned this issue Nov 17, 2020
Merged
9 tasks
makew0rld pushed a commit that referenced this issue Nov 22, 2020
@jedthehumanoid
fix for #103: Simple handling of local (file://) urls (#117)
51fd32e 
Co-authored-by: Mattias Jadelius <mattias.jadelius>
@makew0rld
Copy link
Owner

See #147 for some more about the file:// URI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for #103: Simple handling of local (file://) urls jedthehumanoid/amfora
1 participant
@makew0rld