🔒 Move the administration dashboard to a subdomain #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes authenticate :user from routes.rb file, so it is not a namespace anymore. Instead, dashboard controllers use the authenticate filter to test for user authentication.
Same identifier as the dashboard namespace. Plus, less obvious to people typing random addresses in their browser.
Apply this commit to remove the :dashboard namespace on routes made using the route helper. This means that it is not required anymore to link to a dashboard page using dashboard_video_path, it can be done using video_path. It is not required to use [:dashboard, :videos], :videos can just be used. When linking to a public asset through the dashboard, remember to use the subdomain key in the URL helper to make sure the link points to the appropiate subdomain.
This reverts commit 49489a9. There are conflicts because both dashboard and www have routes using the same name pointing to different URL schemas: playlists_path cannot be at the same time /playlists/ on dashboard and /series/ on www, and playlist_video_path. So I'll have to drop this for now :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is used to move the dashboard from its current route at www.makigas.es/dashboard into a subdomain located at admin.makigas.es. The domain should make use of HTTPS anyway.
The rationale for this change:
This change should not introduce regressions. After configuring the new subdomain and registering an HTTPS certificate, the following should be true: