Update Ruby to 2.4.4 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using ruby:2.4 we ensure we test using upstream Ruby 2.4 version.
danirod
added a commit
that referenced
this pull request
Jun 23, 2018
Note that this only affects the Ruby version used by the Docker container, which is not deployed in production at the moment. (Although it eventually will.) Also note that we've been testing using Ruby 2.4.4 for a long time using the spec Dockerfile, so we already know that makigas.es works on Ruby 2.4.4. Travis-CI now will test against Ruby 2.4 and Ruby 2.5 to prepare for a possible upgrade, although we may just wait until Ruby 2.6 for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this only affects the Ruby version used by the Docker container, which is not deployed in production at the moment. (Although it eventually will.)
Also note that we've been testing using Ruby 2.4.4 for a long time using the spec Dockerfile, so we already know that makigas.es works on Ruby 2.4.4.
Travis-CI now will test against Ruby 2.4 and Ruby 2.5 to prepare for a possible upgrade, although we may just wait until Ruby 2.6 for that.