Honor Do Not Track requests #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will display a banner on top of the page whenever the user browses the page using the DNT header on their browser. To display the banner, the DNT header must have a value of '1'. It won't be triggered if the DNT header has a value of '0' or if the DNT header has no value because the browser does not support it. If the user closes the banner, the browser will set a cookie to acknowledge the user has read the banner, in order not to display the banner anymore on further requests.
To be done: force display Disqus even when DNT is off.
This reverts commit 070b683.
Closed
This commit replaces the check for the DNT header. Instead of looking if the DNT header has a value of "1", it will test if the DNT header has a value starting with the literal '1'. This is done because, according to the DNT standard proposal, there may be DNT extensions in the future after the literal 0 or literal 1. Therefore, it makes sense to only look for the first character of the DNT header, respecting future extensions that add extra data to this header.
danirod
added a commit
that referenced
this pull request
Jun 24, 2018
This PR adds support for Do Not Track. Do Not Track is a Candidate Recommendation for browsers and websites willing to implement a signal sent by web browsers to web servers to indicate server operators the user behind the web browser does not want to be tracked online. makigas.es will not respect the user decision by disabling third party components that cannot respect DNT in a faithfully way whenever the user has enabled DNT. This removes Google Analytics whenever the user has DNT enabled. Neither YouTube embeds nor Disqus have been removed because YouTube embeds are served through youtube-nocookie.com anyway, so there is no risk for information leaks unless the user play those videos. Disqus seems to be respecting DNT according to the docs, so the ban has been lifted as well. Fixes: #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Do Not Track.
Do Not Track is a Candidate Recommendation for browsers and websites willing to implement a signal sent by web browsers to web servers to indicate server operators the user behind the web browser does not want to be tracked online.
makigas.es will not respect the user decision by disabling third party components that cannot respect DNT in a faithfully way whenever the user has enabled DNT. This removes Google Analytics whenever the user has DNT enabled.
Neither YouTube embeds nor Disqus have been removed because YouTube embeds are served through youtube-nocookie.com anyway, so there is no risk for information leaks unless the user play those videos. Disqus seems to be respecting DNT according to the docs, so the ban has been lifted as well.