Issue #79 - Complete or replace default options #98
Conversation
Lonnytunes
force-pushed
the
issue-79-complete-or-replace-default-options
branch
2 times, most recently
from
9e248a7 to
71129f7
Compare
docs/content/backup_restore.md
Outdated
| If you always need to use the same custom options when backing up, you can | ||
| define them as default options in the bundle configuration file: | ||
| By default, those custom options will be added to the [default options](./configuration#default-binary-options) | ||
| defined in the bundle configuration file. Use `--replace-defaults` (`r`) if you |
There was a problem hiding this comment.
may be --override-options
I don't know what is better 🤷
There was a problem hiding this comment.
I agree with with @Lonnytunes, "options" is a too generic word, may be --replace-default-options
docs/content/backup_restore.md
Outdated
| Whether the `--replace-defaults` option is used or not and whether default | ||
| options are defined in the configuration file or not, `--extra-options` option | ||
| value will always override default options from the bundle. |
There was a problem hiding this comment.
I don't understand this sentence? are you sure about it?
There was a problem hiding this comment.
Hum ok I think I see what you mean. I understand why this operate like this (because I know the code behind it), but It's not easy to understand.. :/
There was a problem hiding this comment.
Maybe Backupper and Restorer could have 2 properties: $defaultOptions and $extraOptions ?
Lonnytunes
force-pushed
the
issue-79-complete-or-replace-default-options
branch
from
71129f7 to
e7c9507
Compare
Lonnytunes
force-pushed
the
issue-79-complete-or-replace-default-options
branch
from
e7c9507 to
c3ee9d3
Compare
|
After our discussion IRL and the changes I've made on the code, I prefer to close this PR and create a new one. |
Add the
--replace-defaultsoption to backup and restoration commands to control the behavior of the--extra-optionsoption.