Added initial mypy type checking #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very minimalistic without any type annotations, but in general this is *already as it is* super helpful for uses. Signed-off-by: Sebastian Wagner <sebastian@inter.link>
| import warnings | ||
| from collections import Counter, defaultdict | ||
| from itertools import chain |
There was a problem hiding this comment.
can't explain why this change happened. Any ideas?
There was a problem hiding this comment.
Do you have isort automatically running on save?
There was a problem hiding this comment.
isort is actually always called with tox as it is configured. That's probably why.
|
Thanks, that's great 👍 . I'll try to add some typings. |
|
I added some typings in 05cfa2c if you want to take a look at them and tell me what you think about them. |
|
There are some issue with Python 3.6 I'll check later on https://github.com/makinacorpus/django-safedelete/runs/7861846714?check_suite_focus=true |
|
added a few comments. But 05cfa2c looks great! |
Gagaro
pushed a commit
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very minimalistic without any type annotations,
but in general this is already as it is super helpful for uses.
Signed-off-by: Sebastian Wagner sebastian@inter.link