Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static build support #41

Merged
merged 4 commits into from
Oct 5, 2017
Merged

Static build support #41

merged 4 commits into from
Oct 5, 2017

Conversation

malept
Copy link
Owner

@malept malept commented Oct 5, 2017

Fixes #22.

# Whether to use a statically linked extension.
#
def static_extension?
ENV.key?('RUBY_STATIC') || RbConfig::CONFIG['ENABLE_SHARED'] == 'no'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# The basename of the Rust shared library, as installed in the {#ruby_extension_path}.
#
def shared_library
@shared_library ||= "#{library_name}.so"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently Ruby always expects the file extension to be .so regardless of OS. I guess that makes it simpler.

end

args
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less variable mutation.

@malept
Copy link
Owner Author

malept commented Oct 5, 2017

This passed the Travis CI push check, and the branch is based off of master, so I'm going to just merge.

@malept malept merged commit 145b9bf into master Oct 5, 2017
@malept malept deleted the static-build-support branch October 5, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant