Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header overhaul #399

Closed
1 of 4 tasks
stonier opened this issue May 9, 2018 · 2 comments
Closed
1 of 4 tasks

Header overhaul #399

stonier opened this issue May 9, 2018 · 2 comments
Assignees
Milestone

Comments

@stonier
Copy link
Collaborator

stonier commented May 9, 2018

  • Drop "../../" relative includes, some will be reaching into binary directories anyway
  • Drop global include_directories settings
  • Take advantage of target interface settings for build/install
  • Dump headers over in the include directory, take advantage of delphyne/... (see conversation in [infra] protobuf -> src/protobuf #407)?
@stonier stonier added this to the Milestone #2 milestone May 9, 2018
@stonier stonier self-assigned this May 9, 2018
@stonier
Copy link
Collaborator Author

stonier commented May 10, 2018

GSG:

All of a project's header files should be listed as descendants of the project's source directory without use of UNIX directory shortcuts . (the current directory) or .. (the parent directory). For example, google-awesome-project/src/base/logging.h should be included as:

#include "base/logging.h"

GSG/cpplint is quite a beast. So many rules it's like learning a new language and more than a few don't seem that compelling nor do they fit all use cases.

@stonier stonier modified the milestones: Milestone #2, Milestone #3 May 14, 2018
@stonier
Copy link
Collaborator Author

stonier commented Jun 24, 2018

Remaining work subsumed by #472.

@stonier stonier closed this as completed Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant