[infra] protobuf -> src/protobuf #407
Conversation
Also cleans up the protobuf descriptors generator (cmake) and makes sure the .proto files are installed.
| #include <pybind11/pybind11.h> | ||
|
|
||
| #include <Python.h> | ||
|
|
||
| #include "backend/automotive_simulator.h" |
There was a problem hiding this comment.
protobuf and backend are directories located at the same level in the install folder. Looks a bit odd to me that we include them with different prefixes (see includes from lines 22, 23, 24 and lines 26, 27). One group has the delphyne prefix and not the other.
There was a problem hiding this comment.
These, at the moment, are private headers. Usually I'd just include them as `#include "automotive_simulator.h", but cpplint won't let you do that (google style guide, ugh).
I totally agree, it's confusing ... unless you have a typical bazel package layout.
I'm inclined to eventually move these over to the include directory, regardless of whether they are private or not, but will do that when I do the headers / targets / include_directories overhaul.
|
Looks good to me, just a minor comment about the way we're including headers. |
Also cleans up the protobuf descriptors generator (cmake) and makes
sure the .proto files are installed.
Part of #296