Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proto] moved into source directory #392

Closed
wants to merge 3 commits into from
Closed

[proto] moved into source directory #392

wants to merge 3 commits into from

Conversation

stonier
Copy link
Collaborator

@stonier stonier commented May 5, 2018

No description provided.

@stonier stonier added this to the Milestone #2 milestone May 5, 2018
@stonier
Copy link
Collaborator Author

stonier commented May 7, 2018

The interface dependency for ignition_systems is a bit odd, but I'll clean that up, along with the headers in a forthcoming PR.

@stonier
Copy link
Collaborator Author

stonier commented May 9, 2018 •
edited
Loading

Putting this one on hold till @caguero's #394 is resolved. If we do have custom protobuf cmake glue, we can redirect the location of the headers there.

@stonier stonier closed this May 11, 2018
@stonier stonier deleted the stonier/proto branch May 11, 2018 22:26
@stonier
Copy link
Collaborator Author

stonier commented May 11, 2018

Reopened in #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette Awaiting requested review from clalancette

@caguero caguero Awaiting requested review from caguero

@basicNew basicNew Awaiting requested review from basicNew

@apojomovsky apojomovsky Awaiting requested review from apojomovsky

Assignees
No one assigned
Labels
status: do not merge type: infra
Projects
None yet
Milestone
Milestone #2
Development

Successfully merging this pull request may close these issues.
1 participant
@stonier