-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new custom message for publishing world stats. #409
Conversation
Also cleans up the protobuf descriptors generator (cmake) and makes sure the .proto files are installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reference, the 'D' suffix is there to prevent conflict with the existing world_stats.proto
in ign_msgs.
LGTM pending conflict fixes
@caguero I factored out the hardcoded weight value in a constant and adjusted it so it remains a bit more stable on the UI while still catching up with realtime changes (you can see it in action by running the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requires pull request # 102 from Delphyne Gui.
Generates a custom version of
WorldStatistics
message until we can use the updated message in Ignition Msgs. It also populates thereal_time_factor
field.Note: this PR is built atop pull request #407 , which should be merged first.