Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new custom message for publishing world stats. #409

Merged
merged 7 commits into from
May 25, 2018
Merged

Conversation

caguero
Copy link
Contributor

@caguero caguero commented May 15, 2018

Requires pull request # 102 from Delphyne Gui.

Generates a custom version of WorldStatistics message until we can use the updated message in Ignition Msgs. It also populates the real_time_factor field.

Note: this PR is built atop pull request #407 , which should be merged first.

stonier and others added 2 commits May 11, 2018 18:25
Also cleans up the protobuf descriptors generator (cmake) and makes
sure the .proto files are installed.
@stonier stonier self-requested a review May 15, 2018 03:02
Copy link
Collaborator

@stonier stonier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference, the 'D' suffix is there to prevent conflict with the existing world_stats.proto in ign_msgs.

LGTM pending conflict fixes

@stonier stonier changed the base branch from stonier/protobuf to master May 15, 2018 11:35
@basicNew
Copy link

basicNew commented May 15, 2018

@caguero I factored out the hardcoded weight value in a constant and adjusted it so it remains a bit more stable on the UI while still catching up with realtime changes (you can see it in action by running the realtime_rate_changer.py demo)

Copy link

@basicNew basicNew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caguero caguero merged commit 4883f66 into master May 25, 2018
@caguero caguero deleted the caguero/rtf branch May 25, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants